-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passwordless Auth Core Profiler - Add source
param when sending an email
#96321
Passwordless Auth Core Profiler - Add source
param when sending an email
#96321
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~56 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~73 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~51 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for login and sign up!
One question, it seems the source field also exists on Jetpack Email me a login link
flow, but it's empty. Is this expected?
Pre-approving!
8bWiln.mp4
I'm only see the |
Thanks! I realized we never worked on |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR adds
source
param tosendEmailLogin
function.This is needed in WPCOM to identify the JPC flow and its product (Jetpack, Woo Payments, and Woo Order Attribution). We use this value to use a different email template for the signup and magic link. I'll open a WPCOM PR soon.
Why are these changes being made?
Testing Instructions
config/development.json
.woocommerce/core-profiler-passwordless-auth
feature flag and runyarn start
Continue
button.send-login-email
request and check the payload.source
value.Pre-merge Checklist