-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Add feature list for Jetpack Growth #96335
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
client/my-sites/checkout/src/lib/get-jetpack-product-features.ts
Outdated
Show resolved
Hide resolved
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~251 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~110 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~92 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/my-sites/checkout/src/lib/get-jetpack-product-features.ts
Outdated
Show resolved
Hide resolved
getPathSlug: () => 'growth-monthly', | ||
getProductsIncluded: () => [ | ||
PRODUCT_JETPACK_STATS_MONTHLY, | ||
PRODUCT_JETPACK_SOCIAL_V1_MONTHLY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included v1
instead of advanced
.
biYearly: PLAN_JETPACK_GROWTH_BI_YEARLY, | ||
yearly: PLAN_JETPACK_GROWTH_YEARLY, | ||
monthly: PLAN_JETPACK_GROWTH_MONTHLY, | ||
}, | ||
]; | ||
export const JETPACK_PLANS = < const >[ | ||
PLAN_JETPACK_FREE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few places I see where we could add growth, particularly the upgrade paths where we'd show an upgrade from Growth -> Complete. I'll get those added before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well. I tried the Upgrade button in /me/purchases
but it does not work yet, I think we just have to update that on the backend to work 😄 So i'll go ahead and merge this. Thank you for working on it!
Related to https://github.com/Automattic/jetpack-roadmap/issues/1957
Proposed Changes
Why are these changes being made?
Testing Instructions
/checkout/jetpack/jetpack_growth_yearly
on your local hostPre-merge Checklist