Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Add feature list for Jetpack Growth #96335

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

grzegorz-cp
Copy link
Contributor

@grzegorz-cp grzegorz-cp commented Nov 13, 2024

Related to https://github.com/Automattic/jetpack-roadmap/issues/1957

Proposed Changes

  • add checkout feature list for Jetpack Growth

Why are these changes being made?

  • providing users with more information when purchasing new Jetpack Growth plan

Testing Instructions

  • apply the branch to you local host
  • go to /checkout/jetpack/jetpack_growth_yearly on your local host
  • verify that the features on the left side are populated and you see more than one feature

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@grzegorz-cp grzegorz-cp requested a review from a team as a code owner November 13, 2024 06:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2024
@grzegorz-cp grzegorz-cp self-assigned this Nov 13, 2024
@grzegorz-cp grzegorz-cp requested a review from a team November 13, 2024 06:22
@matticbot
Copy link
Contributor

matticbot commented Nov 13, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/1957-jetpack-growth on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~251 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +871 B  (+0.0%)     +251 B  (+0.0%)
entry-main          +871 B  (+0.0%)     +251 B  (+0.0%)
entry-login         +871 B  (+0.0%)     +251 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~110 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
checkout                                +708 B  (+0.0%)      +92 B  (+0.0%)
jetpack-cloud-features-comparison        +79 B  (+0.0%)      +18 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~92 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                    +708 B  (+0.2%)      +92 B  (+0.1%)
async-load-purchase-modal-wrapper                                                      +708 B  (+0.2%)      +92 B  (+0.1%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       +708 B  (+0.2%)      +92 B  (+0.1%)
async-load-calypso-my-sites-checkout-modal                                             +708 B  (+0.1%)      +92 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                        +708 B  (+0.1%)      +92 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

getPathSlug: () => 'growth-monthly',
getProductsIncluded: () => [
PRODUCT_JETPACK_STATS_MONTHLY,
PRODUCT_JETPACK_SOCIAL_V1_MONTHLY,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included v1 instead of advanced.

biYearly: PLAN_JETPACK_GROWTH_BI_YEARLY,
yearly: PLAN_JETPACK_GROWTH_YEARLY,
monthly: PLAN_JETPACK_GROWTH_MONTHLY,
},
];
export const JETPACK_PLANS = < const >[
PLAN_JETPACK_FREE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places I see where we could add growth, particularly the upgrade paths where we'd show an upgrade from Growth -> Complete. I'll get those added before merging

Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well. I tried the Upgrade button in /me/purchases but it does not work yet, I think we just have to update that on the backend to work 😄 So i'll go ahead and merge this. Thank you for working on it!

@CodeyGuyDylan CodeyGuyDylan merged commit 8058290 into trunk Nov 14, 2024
11 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the add/1957-jetpack-growth branch November 14, 2024 18:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants