Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Show an 'Early Access' banner on the Agency Tier and benefits page. #96339

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

jkguidaven
Copy link
Contributor

This PR adds a disclaimer on the Agency Tier and benefits page that clarifies the early access experience.
Screenshot 2024-11-13 at 4 22 10 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1468

Proposed Changes

  • Create an EarlyAccessBanner component based from the LayoutBanner component. This component can be dismissed, and its dismiss state will be saved as a preference.

Why are these changes being made?

  • This is part of the Agency Tier project and needed before the launch.

Testing Instructions

  • Use the A4A live link and go to the /agency-tier page.
  • Please confirm if the banner is visible. If it isn’t, reset the a4a-agency-tier-early-access-banner-dismissed preference with the Calypso debug tool.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Nov 13, 2024
@jkguidaven jkguidaven requested a review from a team November 13, 2024 08:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2024
@jkguidaven jkguidaven marked this pull request as ready for review November 13, 2024 08:30
@jkguidaven jkguidaven changed the title A4A: Show an 'Early access' banner on the Agency Tier and benefits page. A4A: Show an 'Early Access' banner on the Agency Tier and benefits page. Nov 13, 2024
@matticbot
Copy link
Contributor

matticbot commented Nov 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~225 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-agency-tier       +641 B  (+0.3%)     +225 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@yashwin yashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@simonktnga8c simonktnga8c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jkguidaven 🥳

@jkguidaven jkguidaven force-pushed the add/a4a/agency-tier-early-access-banner branch from 7867772 to a0a9c69 Compare November 13, 2024 10:06
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/agency-tier-early-access-banner on your sandbox.

@jkguidaven jkguidaven merged commit 39253a9 into trunk Nov 13, 2024
11 checks passed
@jkguidaven jkguidaven deleted the add/a4a/agency-tier-early-access-banner branch November 13, 2024 10:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 13, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17001835

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @jkguidaven for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants