-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Show an 'Early Access' banner on the Agency Tier and benefits page. #96339
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~225 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
client/a8c-for-agencies/sections/agency-tier/early-access-banner/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jkguidaven 🥳
7867772
to
a0a9c69
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17001835 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @jkguidaven for including a screenshot in the description! This is really helpful for our translators. |
This PR adds a disclaimer on the Agency Tier and benefits page that clarifies the early access experience.
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1468
Proposed Changes
EarlyAccessBanner
component based from theLayoutBanner
component. This component can be dismissed, and its dismiss state will be saved as a preference.Why are these changes being made?
Testing Instructions
/agency-tier
page.a4a-agency-tier-early-access-banner-dismissed
preference with the Calypso debug tool.Pre-merge Checklist