Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Stats: Add Opens and Clicks tooltips #97729

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Dec 23, 2024

Related to #97638

Proposed Changes

This PR proposes rendering n/a when unique clicks data is unavailable (e.g., when we have clicks but not unique clicks data). It also adds tooltips to display subscribers reached, along with total and unique values.

Screenshot 2024-12-27 at 10 34 36 AM Screenshot 2024-12-27 at 7 31 06 AM
Screen.Recording.2024-12-27.at.7.30.36.AM.mov

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@lezama lezama requested review from crisbusquets and a team December 23, 2024 01:14
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 23, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 23, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-email-tooltip on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 23, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1003 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
stats                                  +2703 B  (+0.2%)     +657 B  (+0.2%)
woocommerce-installation                +105 B  (+0.0%)      +27 B  (+0.0%)
woocommerce                             +105 B  (+0.0%)      +27 B  (+0.0%)
themes                                  +105 B  (+0.0%)      +34 B  (+0.0%)
theme                                   +105 B  (+0.0%)      +34 B  (+0.0%)
subscribers                             +105 B  (+0.0%)      +26 B  (+0.0%)
staging-site                            +105 B  (+0.0%)      +29 B  (+0.0%)
sites-dashboard                         +105 B  (+0.0%)      +29 B  (+0.0%)
site-tools                              +105 B  (+0.0%)      +29 B  (+0.0%)
site-settings                           +105 B  (+0.0%)      +29 B  (+0.0%)
site-purchases                          +105 B  (+0.0%)      +27 B  (+0.0%)
site-performance                        +105 B  (+0.0%)      +29 B  (+0.0%)
site-overview                           +105 B  (+0.0%)      +29 B  (+0.0%)
site-monitoring                         +105 B  (+0.0%)      +29 B  (+0.0%)
site-marketing                          +105 B  (+0.0%)      +29 B  (+0.0%)
site-logs                               +105 B  (+0.0%)      +29 B  (+0.0%)
settings-writing                        +105 B  (+0.0%)      +27 B  (+0.0%)
settings-security                       +105 B  (+0.0%)      +27 B  (+0.0%)
settings-reading                        +105 B  (+0.0%)      +27 B  (+0.0%)
settings-podcast                        +105 B  (+0.0%)      +27 B  (+0.0%)
settings-performance                    +105 B  (+0.0%)      +27 B  (+0.0%)
settings-newsletter                     +105 B  (+0.0%)      +27 B  (+0.0%)
settings-jetpack                        +105 B  (+0.0%)      +27 B  (+0.0%)
settings-discussion                     +105 B  (+0.0%)      +27 B  (+0.0%)
settings                                +105 B  (+0.0%)      +30 B  (+0.0%)
scan                                    +105 B  (+0.0%)      +27 B  (+0.0%)
purchases                               +105 B  (+0.0%)      +27 B  (+0.0%)
promote-post-i2                         +105 B  (+0.0%)      +27 B  (+0.0%)
preview                                 +105 B  (+0.0%)      +27 B  (+0.0%)
posts-custom                            +105 B  (+0.0%)      +30 B  (+0.0%)
posts                                   +105 B  (+0.0%)      +30 B  (+0.0%)
plugins                                 +105 B  (+0.0%)      +29 B  (+0.0%)
plans                                   +105 B  (+0.0%)      +30 B  (+0.0%)
people                                  +105 B  (+0.0%)      +26 B  (+0.0%)
pages                                   +105 B  (+0.0%)      +27 B  (+0.0%)
migrate                                 +105 B  (+0.0%)      +27 B  (+0.0%)
media                                   +105 B  (+0.0%)      +29 B  (+0.0%)
marketplace                             +105 B  (+0.0%)      +34 B  (+0.0%)
marketing                               +105 B  (+0.0%)      +30 B  (+0.0%)
jetpack-social                          +105 B  (+0.0%)      +27 B  (+0.0%)
jetpack-search                          +105 B  (+0.0%)      +27 B  (+0.0%)
jetpack-connect                         +105 B  (+0.0%)      +26 B  (+0.0%)
jetpack-cloud-settings                  +105 B  (+0.0%)      +30 B  (+0.0%)
jetpack-cloud-pricing                   +105 B  (+0.0%)      +27 B  (+0.0%)
jetpack-cloud-plugin-management         +105 B  (+0.0%)      +29 B  (+0.0%)
jetpack-cloud-overview                  +105 B  (+0.0%)      +27 B  (+0.0%)
jetpack-cloud-features-comparison       +105 B  (+0.0%)      +27 B  (+0.0%)
jetpack-cloud                           +105 B  (+0.0%)      +27 B  (+0.0%)
import                                  +105 B  (+0.0%)      +26 B  (+0.0%)
hosting-features                        +105 B  (+0.0%)      +29 B  (+0.0%)
hosting                                 +105 B  (+0.0%)      +29 B  (+0.0%)
home                                    +105 B  (+0.0%)      +30 B  (+0.0%)
gutenberg-editor                        +105 B  (+0.0%)      +27 B  (+0.0%)
google-my-business                      +105 B  (+0.0%)      +27 B  (+0.0%)
github-deployments                      +105 B  (+0.0%)      +29 B  (+0.0%)
export                                  +105 B  (+0.0%)      +27 B  (+0.0%)
email                                   +105 B  (+0.0%)      +26 B  (+0.0%)
earn                                    +105 B  (+0.0%)      +27 B  (+0.0%)
domains                                 +105 B  (+0.0%)      +26 B  (+0.0%)
customize                               +105 B  (+0.0%)      +27 B  (+0.0%)
concierge                               +105 B  (+0.0%)      +27 B  (+0.0%)
comments                                +105 B  (+0.0%)      +27 B  (+0.0%)
checkout                                +105 B  (+0.0%)      +25 B  (+0.0%)
backup                                  +105 B  (+0.0%)      +29 B  (+0.0%)
add-ons                                 +105 B  (+0.0%)      +27 B  (+0.0%)
activity                                +105 B  (+0.0%)      +27 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lezama lezama marked this pull request as ready for review December 27, 2024 09:45
@lezama lezama changed the title Email Stats: Display conversion rates with 2 decimal places and add tooltips Email Stats: Add Opens and Clicks tooltips Dec 27, 2024
@simison
Copy link
Member

simison commented Dec 27, 2024

Something is off with hovering:

Screen.Recording.2024-12-27.at.15.52.22.mov

In Chrome.

@simison
Copy link
Member

simison commented Dec 27, 2024

Overall looking good! Missing unique clicks for some of our stats is worrying be quite a bit, and I had some small issues with hover causing flickering/tooltip not to show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants