Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats: rename 'Subscribers' to 'Newsletters' #97743

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Stats: rename 'Subscribers' to 'Newsletters' #97743

wants to merge 3 commits into from

Conversation

simison
Copy link
Member

@simison simison commented Dec 23, 2024 •
edited
Loading

Resolves Automattic/jetpack#40537

Designs p1HpG7-vch-p2

Proposed Changes

  • Now that "Subscribers" tab contains more than just subscribers (i.e. emails), let's rename it to match product's name.

Before
image

After
Screenshot 2024-12-23 at 14 53 51

Why are these changes being made?

Testing Instructions

  • Head over to Stats and see new tab name. URL still stays the same to make the change simpler.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@simison simison requested a review from a team December 23, 2024 12:55
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-128640
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-128640&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-128640&env=a8c-for-agencies

@simison simison added [Feature] Stats Everything related to our analytics product at /stats/ [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. labels Dec 23, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 23, 2024 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-subscribers-newsletters on your sandbox.

simison
simison commented Dec 23, 2024
View reviewed changes
client/my-sites/stats/stats-subscribers-chart-section/index.tsx
const slugPath = slug ? `/${ slug }` : '';
const pathTemplate = `${ subscribers.path }{{ interval }}${ slugPath }`;
const pathTemplate = `/stats/subscribers/{{ interval }}${ slugPath }`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simplifying the code here, subscribers.label was never used.

simison
simison commented Dec 23, 2024
View reviewed changes
client/my-sites/stats/stats-subscribers-chart-section/index.tsx

const subscribersUrl = isOdysseyStats
const manageSubscribersUrl = isOdysseyStats
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamign for better clarity.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison force-pushed the update/stats-subscribers-newsletters branch from c4af376 to 1897d20 Compare December 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama left review comments

Assignees
No one assigned
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stats: Rename "Subscribers" → "Newsletters"
3 participants
@simison @matticbot @lezama