Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Dashboard: Remove layout-related overrides from Dotcom and A4A #97773

Open
wants to merge 42 commits into
base: trunk
Choose a base branch
from

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Dec 25, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/10139

Proposed Changes

This PR removes layout-related overrides from Dotcom and A4A.

For details of individual overrides, please refer to this post's pfYzsZ-15D-p2 "Style Overrides Removal" and "Remaining Style Overrides" sections.

Why are these changes being made?

https://github.com/Automattic/dotcom-forge/issues/10139

Testing Instructions

On both Calypso and A4A Live;

  • Go to /sites
  • Click any site
  • Ensure nothing breaks

A4A Live

  • Go to /overview
  • Go to /marketplace/assign-license
  • Ensure nothing breaks

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 25, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr changed the base branch from trunk to update/extract-site-overview December 25, 2024 06:54
@okmttdhr okmttdhr force-pushed the update/remove-layout-overrides branch from 0d613ac to 17cf3d6 Compare December 26, 2024 03:33
Base automatically changed from update/extract-site-overview to trunk December 26, 2024 04:52
@okmttdhr okmttdhr changed the title Remove Overrides Sites Dashboard: Remove layout-related overrides from Dotcom and A4A Dec 26, 2024
@okmttdhr okmttdhr self-assigned this Dec 26, 2024
@okmttdhr okmttdhr marked this pull request as ready for review December 26, 2024 22:29
@okmttdhr okmttdhr requested review from a team December 26, 2024 22:30
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 26, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on wpcom and A4A; works well.

We might need to update other hosting pages like Themes, because now they have different border-bottom:

Sites Themes
image image

@andrii-lysenko
Copy link
Contributor

Thank you for working on this.
This seems to work well and I haven't found any issues. The code looks good as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants