Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email comparison: Add email upsell navigation to the compare plans page #97809

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ouikhuan
Copy link
Contributor

@ouikhuan ouikhuan commented Dec 27, 2024

Related to #95813

Proposed Changes

  • Add back and skip button to the email comparison page.

Why are these changes being made?

  • Improve user experiences.

Testing Instructions

  • Go to WP Admin ➡ Hosting ➡ Domains
  • Add a domain
  • Select any domain
  • On the email upsell page, click the "see how they compare" link
  • See if the back button shows up for you in the upsell page
  • See if skip button shows up for you if you already have a domain in cart
  • Click on the link and make sure they navigate to the right page.
Screenshot 2024-12-27 at 2 46 07 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ouikhuan ouikhuan requested a review from a team December 27, 2024 06:48
@ouikhuan ouikhuan self-assigned this Dec 27, 2024
@ouikhuan ouikhuan requested a review from a team as a code owner December 27, 2024 06:48
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 27, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/domain-plan-comparison on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~105 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
email         +811 B  (+0.1%)     +105 B  (+0.0%)
domains       +811 B  (+0.0%)     +105 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants