Skip to content

Commit

Permalink
changelogger: Fix Phan issues (#36755)
Browse files Browse the repository at this point in the history
* changelogger: Fix Phan issues

* Lots of phpdoc fixes.
* Use `??` where applicable.
* Deprecate the `$subheading` parameter to
  `ChangelogEntry::getChangesBySubheading()`, since it makes the return
  value confusing.
* Assign some Symfony HelperInterfaces to variables so we can tell Phan
  the correct type.
* Move most of `WordpressVersioning::normalizeVersion()` to a private
  `WordpressVersioning::normalizeVersionInternal()` so the `$version`
  parameter type can be properly documented.
  * Remove some parameter validation that is no longer needed with it
	being private.
* Fix some `RuntimeException` → `LoadChangeFileException` renames left
  over from #27949.
* Suppress some false positives.
  * Lots due to PHPUnit, sigh.
* Add some missing `@codeCoverageIgnore` to bring the coverage back up.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/8619009165
  • Loading branch information
anomiex authored and matticbot committed Apr 9, 2024
1 parent 21bf16f commit 4cd0b96
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"require-dev": {
"yoast/phpunit-polyfills": "1.1.0",
"automattic/jetpack-changelogger": "^4.1.3-alpha"
"automattic/jetpack-changelogger": "^4.2.0-alpha"
},
"autoload": {
"classmap": [
Expand Down
12 changes: 6 additions & 6 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/automattic/jetpack-device-detection/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"require-dev": {
"yoast/phpunit-polyfills": "1.1.0",
"automattic/jetpack-changelogger": "^4.1.3-alpha"
"automattic/jetpack-changelogger": "^4.2.0-alpha"
},
"suggest": {
"automattic/jetpack-autoloader": "Allow for better interoperability with other plugins that use this package."
Expand Down
4 changes: 2 additions & 2 deletions vendor/composer/installed.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
"dist": {
"type": "path",
"url": "/tmp/jetpack-build/Automattic/jetpack-device-detection",
"reference": "b9e42ec4bcd6972c820c430354226f624579a420"
"reference": "86cada8463bce2573ac3824cac92788cf9024d6e"
},
"require": {
"php": ">=7.0"
},
"require-dev": {
"automattic/jetpack-changelogger": "^4.1.3-alpha",
"automattic/jetpack-changelogger": "^4.2.0-alpha",
"yoast/phpunit-polyfills": "1.1.0"
},
"suggest": {
Expand Down
2 changes: 1 addition & 1 deletion vendor/composer/installed.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
'automattic/jetpack-device-detection' => array(
'pretty_version' => '2.1.3',
'version' => '2.1.3.0',
'reference' => 'b9e42ec4bcd6972c820c430354226f624579a420',
'reference' => '86cada8463bce2573ac3824cac92788cf9024d6e',
'type' => 'jetpack-library',
'install_path' => __DIR__ . '/../automattic/jetpack-device-detection',
'aliases' => array(),
Expand Down

0 comments on commit 4cd0b96

Please sign in to comment.