-
Notifications
You must be signed in to change notification settings - Fork 125
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changelogger: Fix Phan issues (#36755)
* changelogger: Fix Phan issues * Lots of phpdoc fixes. * Use `??` where applicable. * Deprecate the `$subheading` parameter to `ChangelogEntry::getChangesBySubheading()`, since it makes the return value confusing. * Assign some Symfony HelperInterfaces to variables so we can tell Phan the correct type. * Move most of `WordpressVersioning::normalizeVersion()` to a private `WordpressVersioning::normalizeVersionInternal()` so the `$version` parameter type can be properly documented. * Remove some parameter validation that is no longer needed with it being private. * Fix some `RuntimeException` → `LoadChangeFileException` renames left over from #27949. * Suppress some false positives. * Lots due to PHPUnit, sigh. * Add some missing `@codeCoverageIgnore` to bring the coverage back up. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/8619009165
- Loading branch information
Showing
5 changed files
with
11 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters