Skip to content

Commit

Permalink
Fix obviously wrong class name references (#36769)
Browse files Browse the repository at this point in the history
Almost all are phpdoc comments where the class was missing a `use` or
leading `\`. More specifically, I searched for cases where Phan was
complaining about classes named like `\Automattic\...\Automattic\`, or
`\WP_...`, or `Exception` classes, and fixed all the obvious ones.

Then I also searched for "undeclared {class|type} \[a-z]" and fixed the
obvious ones out of that too (e.g. "obj", "number", and various typos).

Note that having the correct typing allows Phan to complain about
possibly-real issues in some cases. Those will have to be reviewed
later.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/8596601938
  • Loading branch information
anomiex authored and matticbot committed Apr 8, 2024
1 parent 6287659 commit 6503275
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions vendor/composer/installed.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"packages": [
{
"name": "automattic/jetpack-device-detection",
"version": "2.1.3-alpha.1712265966",
"version_normalized": "2.1.3.0-alpha1712265966",
"version": "2.1.3-alpha.1712563319",
"version_normalized": "2.1.3.0-alpha1712563319",
"dist": {
"type": "path",
"url": "/tmp/jetpack-build/Automattic/jetpack-device-detection",
"reference": "69f6d2a5495e2c609d6c9523de438b49cc18021c"
"reference": "a9b7de14c343d0351f22ffce79d397bc5987e039"
},
"require": {
"php": ">=7.0"
Expand Down
6 changes: 3 additions & 3 deletions vendor/composer/installed.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
),
'versions' => array(
'automattic/jetpack-device-detection' => array(
'pretty_version' => '2.1.3-alpha.1712265966',
'version' => '2.1.3.0-alpha1712265966',
'reference' => '69f6d2a5495e2c609d6c9523de438b49cc18021c',
'pretty_version' => '2.1.3-alpha.1712563319',
'version' => '2.1.3.0-alpha1712563319',
'reference' => 'a9b7de14c343d0351f22ffce79d397bc5987e039',
'type' => 'jetpack-library',
'install_path' => __DIR__ . '/../automattic/jetpack-device-detection',
'aliases' => array(),
Expand Down

0 comments on commit 6503275

Please sign in to comment.