Skip to content

Commit

Permalink
changelogger: Support symfony/console 7.0 (#36861)
Browse files Browse the repository at this point in the history
When I tried using stub-generator from Packagist, it broke because it
wasn't actually compatible with symfony/console 7.0 (it needed
specification of a return type on a method). Turns out this is because
changelogger only specified working with up to 6.0, so 7.0 wasn't being
used when it should have been.

Fortunately all the changes are still more-or-less backwards compatible
all the way back to the 3.4 version we need for PHP 7.0 support. We wind
up having to specify the commands' names and descriptions twice now,
but 🤷.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/8662487279
  • Loading branch information
anomiex authored and matticbot committed Apr 12, 2024
1 parent 1e0dfdd commit e960b3e
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"require-dev": {
"yoast/phpunit-polyfills": "1.1.0",
"automattic/jetpack-changelogger": "^4.2.0"
"automattic/jetpack-changelogger": "^4.2.1-alpha"
},
"autoload": {
"classmap": [
Expand Down
14 changes: 7 additions & 7 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/automattic/jetpack-device-detection/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"require-dev": {
"yoast/phpunit-polyfills": "1.1.0",
"automattic/jetpack-changelogger": "^4.2.0"
"automattic/jetpack-changelogger": "^4.2.1-alpha"
},
"suggest": {
"automattic/jetpack-autoloader": "Allow for better interoperability with other plugins that use this package."
Expand Down
4 changes: 2 additions & 2 deletions vendor/composer/installed.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
"dist": {
"type": "path",
"url": "/tmp/jetpack-build/Automattic/jetpack-device-detection",
"reference": "449b2fe73f4b55ed29d1f18cda8a5d5aa3a245bd"
"reference": "1556cd1f7176e8f7dd22d735ba583480114d9589"
},
"require": {
"php": ">=7.0"
},
"require-dev": {
"automattic/jetpack-changelogger": "^4.2.0",
"automattic/jetpack-changelogger": "^4.2.1-alpha",
"yoast/phpunit-polyfills": "1.1.0"
},
"suggest": {
Expand Down
2 changes: 1 addition & 1 deletion vendor/composer/installed.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
'automattic/jetpack-device-detection' => array(
'pretty_version' => '2.1.3',
'version' => '2.1.3.0',
'reference' => '449b2fe73f4b55ed29d1f18cda8a5d5aa3a245bd',
'reference' => '1556cd1f7176e8f7dd22d735ba583480114d9589',
'type' => 'jetpack-library',
'install_path' => __DIR__ . '/../automattic/jetpack-device-detection',
'aliases' => array(),
Expand Down

0 comments on commit e960b3e

Please sign in to comment.