New task management #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
approved these changes
Nov 11, 2024
aggregator/rpc_server.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func (r *RpcServer) CancelTask(ctx context.Context, taskID *avsproto.UUID) (*wrapperspb.BoolValue, error) { | ||
| user, err := r.verifyAuth(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, status.Errorf(codes.Unauthenticated, "invalid authentication key") |
There was a problem hiding this comment.
Let’s capitalize the first word of error messages, "Invalid".
Also, I’d suggest us to create a list of constant for the error message, for code re-use purpose.
There was a problem hiding this comment.
hmm, is this PR supposed to be on top of #33?
There was a problem hiding this comment.
- create task with specific wallet - list task by the smart wallet - return all task data in list
v9n
force-pushed
the
new-task-management
branch
from
33538ce to
aaa7740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.