Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Iframe tip #714

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Update Iframe tip #714

merged 3 commits into from
Nov 8, 2023

Conversation

FlorianJacta
Copy link
Member

@FlorianJacta FlorianJacta commented Nov 6, 2023 •
edited by FabienLelaquais
Loading

Addresses #711.

Change illustration before merging @marisogo

@FlorianJacta FlorianJacta self-assigned this Nov 6, 2023
FabienLelaquais
FabienLelaquais requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typography details.
And please rename 'third_part_objects' to '3rd_party_components' or something

docs/knowledge_base/tips/index.md Show resolved Hide resolved
docs/knowledge_base/tips/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/tips/third_party_objects/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/tips/third_party_objects/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/tips/third_party_objects/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/tips/third_party_objects/index.md Outdated Show resolved Hide resolved
docs/knowledge_base/tips/index.md Outdated Show resolved Hide resolved
FabienLelaquais
FabienLelaquais approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌

@FlorianJacta FlorianJacta merged commit 56ab1a9 into develop Nov 8, 2023
1 check passed
@FlorianJacta FlorianJacta deleted the doc/update-iframe-tip branch November 8, 2023 15:04
@FlorianJacta FlorianJacta restored the doc/update-iframe-tip branch November 8, 2023 15:36
@FabienLelaquais FabienLelaquais added 📈 Improvement Improvement of a feature. 📄 Documentation Internal or public documentation 🟧 Priority: High Stalls work on the project or its dependents labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

Assignees

@FlorianJacta FlorianJacta

Labels
📄 Documentation Internal or public documentation 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianJacta @FabienLelaquais