Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table layout unexpected change #2477

Merged
merged 9 commits into from
Mar 5, 2025
Merged

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Mar 4, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

table layout change when

  • cell re-render
  • another table has a action/edit column

and a few little fixes

big Thank you to @FabienLelaquais for his help and insight

Related Tickets & Documents

How to reproduce the issue

sort a column to show the table layout change

import taipy.gui.builder as tgb
from taipy.gui import Gui, State

inputs = {
        "Item Code": ["A00001", "A00002", "A00003", "B10000"],
        "Item Description": ["J.B. Officeprint 1420","J.B. Officeprint 1111","J.B. Officeprint 1186","Printer Label"],
        "Expectation Factor": [1, 1.2, 1, 1.5],
        "Production Time (days)": [5, 2, 3, 4],
        "Arrival Time (days)": [1, 2, 1, 1],
        "Minimal Stock": [100, 200, 150, 200],
    }


recommendations = {
        "Order Quantity": [100, 120],
        "Order Date": ["2021-01-01", "2021-01-01"],
        "Delivery Date": ["2021-01-06", "2021-01-03"],
        }

def on_action(state: State) -> None:
    state.refresh("inputs")


# Create the Taipy page
with tgb.Page() as page:
    tgb.table("{inputs}", show_all=True)
    tgb.table("{recommendations}", filter=True, show_all=True)


# Run the Taipy app
if __name__ == "__main__":
    Gui(page=page).run(title="2217 table refresh")

- cell re-render
- another table has a action/edit column
resolves #2217
@FredLL-Avaiga FredLL-Avaiga added 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels Mar 4, 2025
@FredLL-Avaiga FredLL-Avaiga self-assigned this Mar 4, 2025
FabienLelaquais
FabienLelaquais previously approved these changes Mar 4, 2025
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

make return coherent
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 645d6a2

FabienLelaquais
FabienLelaquais previously approved these changes Mar 5, 2025
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Fred Lefévère-Laoide added 2 commits March 5, 2025 10:57
FabienLelaquais
FabienLelaquais previously approved these changes Mar 5, 2025
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga merged commit 111f060 into develop Mar 5, 2025
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2217-table-layout-change branch March 5, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Reading a data node changes the display of a table
2 participants