Enable compiled bindings by default #10880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hez2010 for 11.0 we didn't plan to enable compiled bindings by default in all projects, but only in new templates (which was already done). |
|
You can test this PR using the following package version. |
|
There are known cases where compiled bindings still don't work (example: #2725). I would not enable this by default yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Enable compiled bindings by default.
It's really easy to forget to enable compiled bindings.
So we can just enforce it by default, while users can still opt-out compiled bindings by using
/p:AvaloniaUseCompiledBindingsByDefault=false.This can contribute to help the entire community build a trimming-compatible ecosystem.
What is the current behavior?
Compiled bindings are off by default.
What is the updated/expected behavior with this PR?
Enable it by default.
Breaking changes
Now compiled bindings are enabled by default.