Skip to content

Conversation

hukela
Copy link

@hukela hukela commented Sep 4, 2025

In the original example:
The GetInstalledFontFamilyNames method has been removed.
The Items property of ComboBox has been set to read-only and cannot be directly assigned.
Therefore, I have rewritten this example.

In the original example:
The `GetInstalledFontFamilyNames` method has been removed.
The `Items` property of `ComboBox` has been set to read-only and cannot be directly assigned.
Therefore, I have rewritten this example.
Copy link
Contributor

@timunie timunie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the Window-tag around the sample is not needed. In case you have a mobile App for example there is even no window, so for newbies it can be also missleading. Otherwise the changes are looking good to me.

Remove the Window-tag that should not appear in the case.
@hukela
Copy link
Author

hukela commented Sep 20, 2025

I was wondering about this earlier, thanks for providing the reason. The Window-tag has now been deleted. I'm not sure if I should directly add a commit? Or should I create a new merge request to combine both changes in a single commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants