Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerricodelacruz/issue83 #88

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

jerricotandelacruz
Copy link
Contributor

Combine Icon view and list view

@Sealjay
Copy link
Member

Sealjay commented Jan 26, 2022

@jerricodelacruz - was this meant to be merged?

@Sealjay Sealjay reopened this Jan 26, 2022
@jerricotandelacruz
Copy link
Contributor Author

@jerricodelacruz - was this meant to be merged?

I was not meant to combine it in main branch. I was just combining the issue 82 and 83 branch.

@jerricotandelacruz
Copy link
Contributor Author

jerricotandelacruz commented Jan 27, 2022

@Sealjay & @FergusKidd

This request is ready for review. It covers the Issue #83 and Issue #82 .
Remarks : I included the dummy data to display Icon view and List view.

Closes #82
Closes #83

@Sealjay Sealjay requested review from Sealjay and removed request for FergusKidd January 27, 2022 10:13
Copy link
Member

@Sealjay Sealjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge, some comments


const handleSelect = (id : number) => {
setSelectedId(id);
}

const selectView = (view) => {
setSelectedView(view);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using an off the shelf PDF viewer or creating one that can support other office document types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now we are still looking for the package for pdf viewer and other types of documents. Do you have any suggestion package that we can use?

Issue #81 Document viewer page - @dennisdelamida

@Sealjay
Copy link
Member

Sealjay commented Jan 27, 2022

@Sealjay & @FergusKidd

This request is ready for review. It covers the Issue #83 and Issue #82 .

Remarks : I included the dummy data to display Icon view and List view.

Closes #82

Closes #83

Approved for merge @jerricodelacruz (feel free to merge yourself when approved, then delete the dangling branch) - some comments about the document viewer

This was linked to issues Jan 27, 2022
@jerricotandelacruz jerricotandelacruz merged commit d6398a0 into jerricodelacruz/issue82 Jan 27, 2022
@jerricotandelacruz jerricotandelacruz deleted the jerricodelacruz/issue83 branch January 27, 2022 13:50
@jerricotandelacruz jerricotandelacruz linked an issue Jan 27, 2022 that may be closed by this pull request
@jerricotandelacruz jerricotandelacruz restored the jerricodelacruz/issue83 branch January 27, 2022 14:36
@FergusKidd FergusKidd deleted the jerricodelacruz/issue83 branch January 28, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document list view page Document icons view page
2 participants