-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jerricodelacruz/issue83 #88
Jerricodelacruz/issue83 #88
Conversation
@jerricodelacruz - was this meant to be merged? |
I was not meant to combine it in main branch. I was just combining the issue 82 and 83 branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for merge, some comments
|
||
const handleSelect = (id : number) => { | ||
setSelectedId(id); | ||
} | ||
|
||
const selectView = (view) => { | ||
setSelectedView(view); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using an off the shelf PDF viewer or creating one that can support other office document types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now we are still looking for the package for pdf viewer and other types of documents. Do you have any suggestion package that we can use?
Issue #81 Document viewer page - @dennisdelamida
Approved for merge @jerricodelacruz (feel free to merge yourself when approved, then delete the dangling branch) - some comments about the document viewer |
Combine Icon view and list view