Adding support for Key IDs longer than 10 characters #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that for individual API keys the Key ID can be longer than 10 characters, so this is necessary (provided the naming scheme of `ApiKey_<keyId>.p8` remains stable). The `reversed()` dance could be avoided by introducing a dependency on [swift-algorithms](https://github.com/apple/swift-algorithms/tree/main) which provides `suffix(while:)`.
|
Maybe we should lift the 10 characters limit in line 99 also. |
|
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
|
@AvdLee @polpielladev thoughts? |
polpielladev
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that for individual API keys the Key ID can be longer than 10 characters, so this is necessary (provided the naming scheme of
ApiKey_<keyId>.p8remains stable).The
reversed()dance could be avoided by introducing a dependency on swift-algorithms which providessuffix(while:).