Big Boi Refactor #135
Closed
Big Boi Refactor #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main things I want to explore here are:
|
|
Sammy99jsp
force-pushed
the
sammy99jsp-refactor
branch
from
4f90bd0 to
2594e12
Compare
|
For my own sanity, this will be moving over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I have no idea what's happening with the codebase after coming back from like 2 months.
Hopefully, this time there'll be slightly more separation of concerns.
Anyway, I'll be updating the repo with new issues which will hopefully be solved in smaller PRs.
This PR is mainly to press a big, giant “merge” button at the end.