Skip to content

Commit

Permalink
fix(a11y): remove double aria-label
Browse files Browse the repository at this point in the history
  • Loading branch information
@MartinWeb
JELTI AMINE authored and MartinWeb committed Dec 11, 2023
1 parent 95505df commit 83c1ebb
Show file tree
Hide file tree
Showing 13 changed files with 0 additions and 25 deletions.
1 change: 0 additions & 1 deletion packages/Form/Input/checkbox/src/__tests__/__snapshots__/CheckboxInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`<DateInput> renders DateInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
for="id"
>
Expand Down
4 changes: 0 additions & 4 deletions packages/Form/Input/choice/src/__tests__/__snapshots__/Choice.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`<ChoiceInput> renders ChoiceInput correctly when passing options with I
class="col-md-2"
>
<label
aria-label="Some label"
class="af-form__group-label"
for="xxx_Yes"
>
Expand Down Expand Up @@ -75,7 +74,6 @@ exports[`<ChoiceInput> renders ChoiceInput correctly when passing options withou
class="col-md-2"
>
<label
aria-label="Some label"
class="af-form__group-label"
for="1"
>
Expand Down Expand Up @@ -141,7 +139,6 @@ exports[`<ChoiceInput> renders ChoiceInput correctly with default options 1`] =
class="col-md-2"
>
<label
aria-label="Some label"
class="af-form__group-label"
for="oui"
>
Expand Down Expand Up @@ -207,7 +204,6 @@ exports[`<ChoiceInput> renders ChoiceInput correctly with required 1`] = `
class="col-md-2"
>
<label
aria-label="Some label"
class="af-form__group-label"
for="oui"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/file/src/__tests__/__snapshots__/FileInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`<FileInput> renders FileInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="File *"
class="af-form__group-label"
for="id"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/number/src/__tests__/__snapshots__/NumberInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`<NumberInput> renders NumberInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
for="iddateinput"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/radio/src/__tests__/__snapshots__/RadioInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ exports[`<RadioInput /> should have correct html rendered 1`] = `
class="col-md-2"
>
<label
aria-label="test"
class="af-form__group-label"
>
test
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/select-multi/src/__tests__/__snapshots__/MultiSelectInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,6 @@ exports[`renders MultiSelectInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="Place type *"
class="af-form__group-label"
for="multiselectid"
>
Expand Down
2 changes: 0 additions & 2 deletions packages/Form/Input/select/src/__tests__/__snapshots__/Select.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ exports[`renders SelectInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="label"
class="af-form__group-label"
for="muid"
>
Expand Down Expand Up @@ -222,7 +221,6 @@ exports[`renders SelectInput correctly with classModier 1`] = `
class="col-md-2"
>
<label
aria-label="label"
class="af-form__group-label"
for="muid"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/slider/src/__tests__/__snapshots__/SliderInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`<SliderInput> renders SliderInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="File *"
class="af-form__group-label"
for="id"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/switch/src/__tests__/__snapshots__/SwitchInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ exports[`<SwitchInput> renders SwitchInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
>
Image *
Expand Down
3 changes: 0 additions & 3 deletions packages/Form/Input/text/src/__tests__/__snapshots__/TextInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`TextInput renders TextInput correctly with child 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
for="iddateinput"
>
Expand Down Expand Up @@ -49,7 +48,6 @@ exports[`TextInput renders TextInput correctly with classModifier 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
for="iddateinput"
>
Expand Down Expand Up @@ -86,7 +84,6 @@ exports[`TextInput renders TextInput correctly with error message 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
for="iddateinput"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/Input/textarea/src/__tests__/__snapshots__/TextareaInput.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`renders TextareaInput correctly 1`] = `
class="col-md-2"
>
<label
aria-label="Image *"
class="af-form__group-label"
for="iddateinput"
>
Expand Down
1 change: 0 additions & 1 deletion packages/Form/core/src/Field.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const Field = ({
<div className={classNameContainerLabel}>
<label
className="af-form__group-label"
aria-label={label.toString()}
htmlFor={isLabelContainerLinkedToInput ? id : null}>
{label}
</label>
Expand Down
7 changes: 0 additions & 7 deletions packages/Form/core/src/__tests__/__snapshots__/Field.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`<Field> Render <Field/> when have children HelpMessage 1`] = `
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand Down Expand Up @@ -38,7 +37,6 @@ exports[`<Field> Render <Field/> when have children HelpMessage and have message
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand Down Expand Up @@ -74,7 +72,6 @@ exports[`<Field> Render <Field/> when have children complete example with error
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand Down Expand Up @@ -120,7 +117,6 @@ exports[`<Field> Render <Field/> when have children complete example without err
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand Down Expand Up @@ -158,7 +154,6 @@ exports[`<Field> Render <Field/> when have message and forceDisplayMessage equal
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand Down Expand Up @@ -196,7 +191,6 @@ exports[`<Field> Render <Field/> when is visible 1`] = `
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand All @@ -221,7 +215,6 @@ exports[`<Field> Render <Field/> with roleContainer and ariaLabelContainer 1`] =
class="col-md-2"
>
<label
aria-label="my label"
class="af-form__group-label"
for=""
>
Expand Down

0 comments on commit 83c1ebb

Please sign in to comment.