Refactor/modal #1048
Merged
Refactor/modal #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.storybook/preview.js
Outdated
| @@ -5,7 +5,7 @@ import '../packages/all/dist/style/af-toolkit-core.css'; | |||
| import '../packages/core/dist/assets/fonts/icons/af-icons.css'; | |||
| import './storybook.css'; | |||
|
|
|||
| export const decorators = [addReadme]; | |||
| // export const decorators = [addReadme]; | |||
There was a problem hiding this comment.
Why comment an export and not delete it if it's no longer used ?
| import { useRef } from 'react'; | ||
|
|
||
| export const YourComponent = () => { | ||
| const ref = useRef < HTMLDialogElement > null; |
There was a problem hiding this comment.
Suggested change
| const ref = useRef < HTMLDialogElement > null; | |
| const ref = useRef<HTMLDialogElement>(null); |
|
|
||
| ### Use | ||
| export const YourComponent = () => { | ||
| const ref = useRef < HTMLDialogElement > null; |
There was a problem hiding this comment.
Suggested change
| const ref = useRef < HTMLDialogElement > null; | |
| const ref = useRef<HTMLDialogElement>(null); |
MartinWeb
force-pushed
the
refactor/modal
branch
3 times, most recently
from
424b469 to
c2404f2
Compare
samuel-gomez
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Bug
Person(s) for reviewing proposed changes
@arnaudforaison @samuel-gomez @JLou @buddyvegas
Important
This pull request introduces breaking changes :