[Storybook] Suppression du header bleu uniquement lors du build de storybook #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforatier
previously approved these changes
Mar 17, 2021
|
Pas de préférences pour ma part. Légère tendance au minimalisme mais bon le logo a du sens ici. |
bernard-arnaud
previously approved these changes
Mar 19, 2021
|
Préfèrence pour la proposition 2 afin d'avoir l'information de suite, ce qui me semble important pour une lib. Une autre solution serait d'afficher la version en-dessous des logos ? |
|
Préférence pour le 2sd thème, surtout que l'on pourrait mettre un logo en favicon |
arnaudforaison
dismissed stale reviews from bernard-arnaud and jforatier
via
60d7aed
arnaudforaison
force-pushed
the
theme-storybook
branch
from
2efc854 to
60d7aed
Compare
|
Ajouter logo + titre version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After - proposition 1
After - proposition 2
Donner moi votre avis sur les propositions, ainsi que vos retours de PR.
But ici: supprimer le script
inject-version