chore!: refactor plugin instantiation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| /** | ||
| * Initializes plugin. | ||
| */ | ||
| function init(): void { |
There was a problem hiding this comment.
Method init has 54 lines of code (exceeds 25 allowed). Consider refactoring.
| * | ||
| * @return array<string, string> List of dependencies that are not ready. | ||
| */ | ||
| function dependencies_not_ready(): array { |
There was a problem hiding this comment.
Function dependencies_not_ready has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR refactors the plugin instantiation. More specifically:
WPGraphQL/RankMathnamespace to root-level files:activation.php,deactivation.php,wp-graphql-rank-math.php, and cleanup the internal methods.Autoloaderclass.Why
How
Testing Instructions
Additional Info
Checklist: