-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Michaelos strategy #1091
Merged
Merged
Michaelos strategy #1091
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
20d4be9
NTitsForMTats player added
Chadys dbfb9f2
tests for NTitsForMTats
Chadys 2e246da
Remove SlowTitForTwoTats as duplicate of TitFor2Tats (#1073)
Chadys 2631c02
docstring update
Chadys dc58ba8
update count of memory one strategies in example
Chadys 6ade0fd
added memory depth change test
Chadys c16de25
Revert "update count of memory one strategies in example"
Chadys 1aef132
remove NTitsForMTats from strategies to avoid having two instances of…
Chadys 2cab969
update number of strategies with short memory length because of the r…
Chadys b1d5f8b
Change NTitsForMTats default values
Chadys 862b10c
correct NTitsForMTats tests to reflect changes in default values
Chadys a9cbf02
Remove check for matplotlib installed
drvinceknight 52827c7
Remove hypothesis from setup.
drvinceknight 8783b18
Release v3.2.0
drvinceknight 371a2b2
Fix spacing
dmanc 5e1272d
Add Michaelos strategy from LessWrong
dmanc c22d58a
Add Michaelos to strategies list
dmanc 29545ec
Add test for Michealos strategy
dmanc ae41d6c
Fix doctest
dmanc 7a10e4b
Fix typo
dmanc 8ac65c6
Update master
dmanc 07e4396
Merge branch with master
dmanc 13c5635
Add requested changes
dmanc e02e232
Fix merge conflicts
dmanc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you repeat this test with a different seed to show differing behaviour after
(C, D)
(so only need 4 round please):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I don't think this scenario is possible for the strategy unless I am misinterpreting something. After (C, D) Michaelos will play D since it is still playing like Tit-for-Tat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the second test, does tweaking the test mean changing the expected actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry you're correct, that was a typo from me, I simply mean to include a random seed version to illustrate that 50% of the time after
(D, C)
(not(C, D)
- sorry) the strategy will cooperate **and **is_defector
will be False (so kind of like yourseed=1
test but without the second(C, D)
.Yes.