-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump deps #1446
bump deps #1446
Conversation
Some of the types have changed, causing test failures like so:
To be clear this appears to be due to numpy changes, not any of our type hints. |
yep, this is an issue with tox + numpy. tox appears to default to using latest numpy version which, as you mention, gives us some problems. Reverting to numpy 1.26.4 seems to solve issue |
@@ -27,6 +27,7 @@ deps = | |||
pytest-sugar | |||
isort | |||
black | |||
numpy==1.26.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pin this in pyproject.toml
instead of here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its in there as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In there it's not hard pinned. Just a lower bound. I wonder if it's worth hard pinning it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have avoided doing this in the past (I think mainly on my request?) but I wonder if it's worth starting to do (in our installation docs we do recommend using a venv etc...)...
We shouldn't delay merging this though, @miller-ian's contribution is a super helpful bug fix that lets other PRs get through :)
Thanks for this: it looks good to me. |
numpy + tox issues resolved with upgrade to numpy version 1.26.4
Tox py312 defaults to using numpy 2.0. Some numpy issues have been identified here and here. Dictating numpy version 1.26.4 (most recent version prior to 2.0) in tox.ini file resolves issues