-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get mypy working again #1457
base: dev
Are you sure you want to change the base?
Get mypy working again #1457
Conversation
Need to test adding new exception handling. Will reopen. |
Looks like this is failing on coverage:
|
But why? That line is tested. Any idea? |
Could it be the |
I actually had assertRaises that I changed thinking perhaps it wanted to test the text of the error message. |
Ah, so get_data raises FileNotFoundError in my test case, but returns None for some other kinda failure. I'll figure it out. |
I chose to inject the dependency on
|
Oh, mypy is giving a lot more errors. I'm not sure why I thought it was resolved. Will reopen after addressing the others. |
Ah, this was passing locally. I'm gonna continue to test via CI / build |
Everything seems to be passing now. |
Resolves #1406