Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline V2 DTL Callback #155

Closed
wants to merge 164 commits into from
Closed

Baseline V2 DTL Callback #155

wants to merge 164 commits into from

Conversation

0xJem
Copy link
Contributor

@0xJem 0xJem commented Apr 17, 2024 •
edited
Loading

  • Implements a DTL callback that deposits all of the auction proceeds into an existing (but not initialised) Baseline V2 stack. Also includes allowlist variants.
  • Adds scripts for working with FPB & Baseline Allocated Allowlist auctions: create, place bid, settle
  • Improvements to salt generation scripts to reduce redundant code and values

TODOs:

  • Get tick ranges reviewed by Baseline
  • Scripts to set up Baseline stack

@0xJem 0xJem force-pushed the baseline-v2-dtl branch 2 times, most recently from df38c3d to c454db1 Compare April 24, 2024 11:45
@0xJem 0xJem force-pushed the baseline-v2-dtl branch from c454db1 to 914f86f Compare April 24, 2024 11:49
@0xJem 0xJem changed the title Baseline V2 DTL Callback [DRAFT] Baseline V2 DTL Callback Apr 25, 2024
Base automatically changed from uniswap-v2-dtl to develop April 29, 2024 14:48
@Oighty Oighty changed the base branch from develop to fixed-batch May 20, 2024 02:29
@0xJem 0xJem requested a review from Oighty June 21, 2024 12:32
Oighty
Oighty reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Oighty Oighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callback updates look good.

src/callbacks/liquidity/BaselineV2/BaselineAxisLaunch.sol Show resolved Hide resolved
0xJem added 15 commits June 25, 2024 10:41
@0xJem 0xJem changed the title [DRAFT] Baseline V2 DTL Callback Baseline V2 DTL Callback Jul 12, 2024
@0xJem 0xJem linked an issue Jul 15, 2024 that may be closed by this pull request
Callbacks: Baseline V2 #156
Closed
@0xJem 0xJem mentioned this pull request Jul 17, 2024
Merged
2 tasks
@0xJem
Copy link
Contributor Author

0xJem commented Jul 17, 2024

I propose closing this PR, as the code has been moved into axis-periphery and axis-utils

@Oighty Oighty closed this Jul 17, 2024
@0xJem 0xJem deleted the baseline-v2-dtl branch July 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oighty Oighty Oighty left review comments

@ind-igo ind-igo Awaiting requested review from ind-igo

Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callbacks: Baseline V2
3 participants
@0xJem @ind-igo @Oighty