Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction Management #17

Merged
merged 44 commits into from
Jan 11, 2024
Merged

Auction Management #17

merged 44 commits into from
Jan 11, 2024

Conversation

0xJem
Copy link
Contributor

@0xJem 0xJem commented Jan 5, 2024

  • auction creation
    • allowlist
    • hooks
  • auction cancellation

@0xJem 0xJem self-assigned this Jan 5, 2024
@0xJem 0xJem linked an issue Jan 5, 2024 that may be closed by this pull request
Base automatically changed from jem/module-management to master January 9, 2024 06:50
@0xJem 0xJem requested a review from Oighty January 10, 2024 12:45
@0xJem
Copy link
Contributor Author

0xJem commented Jan 10, 2024

I've merged in the changes from the cleanup branch and fixed any outstanding issues

Copy link
Contributor

@Oighty Oighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I refactored the fee function a bit to use fewer storage loads.

@Oighty Oighty merged commit d774664 into master Jan 11, 2024
1 check passed
@Oighty Oighty deleted the jem/auction-management branch January 11, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auction House: Auction Creation and Management
2 participants