Code

Audit Fixes: Uniswap DTL#12

Code

Merged

0xJem merged 49 commits intobaseline-updatesAxis-Fi/axis-periphery:baseline-updatesfrom uniswap-dtl-fixesAxis-Fi/axis-periphery:uniswap-dtl-fixesCopy head branch name to clipboardAug 14, 2024

+2,170-722

Commits

Commits on Jul 31, 2024

• Cross-port contract docs in BaseDTL

  0xJem

  committed
  14c2ea9

  Copy full SHA for 14c2ea9

• Lead-M-01: address DoS of lot creation through existing pair

  0xJem

  committed
  d9a0fc1

  Copy full SHA for d9a0fc1

• Fix linting warnings

  0xJem

  committed
  be5adcf

  Copy full SHA for be5adcf

• Lead-L-01: validation of active flag

  0xJem

  committed
  81e08e5

  Copy full SHA for 81e08e5

• C-01 and L-08: check callback data length, move maxSlippage into onCreate

  0xJem

  committed
  04e73e9

  Copy full SHA for 04e73e9

Commits on Aug 1, 2024

• Add proof of concept test

  0xJem

  committed
  bb9ac61

  Copy full SHA for bb9ac61

• Test TODOs

  0xJem

  committed
  b8bdb54

  Copy full SHA for b8bdb54

• Initial version working. Test passes.

  0xJem

  committed
  e724152

  Copy full SHA for e724152

• Test stubs

  0xJem

  committed
  b4f8a85

  Copy full SHA for b4f8a85

• Improve initial (simple) tests

  0xJem

  committed
  170ca4f

  Copy full SHA for 170ca4f

• Quote token tests

  0xJem

  committed
  7c4250c

  Copy full SHA for 7c4250c

• Flawed approach to resolving donate-and-sync. Committing as a reference point.

  0xJem

  committed
  81b8855

  Copy full SHA for 81b8855

• Remove redundant code, document new approach

  0xJem

  committed
  329af9b

  Copy full SHA for 329af9b

Commits on Aug 2, 2024

• Add fuzz tests for price and quote token amount

  0xJem

  committed
  37d833b

  Copy full SHA for 37d833b

• Initial pass at swap approach

  0xJem

  committed
  f00a0db

  Copy full SHA for f00a0db

• Refactor to avoid stack too deep

  0xJem

  committed
  578f199

  Copy full SHA for 578f199

• Revised approach to swap. Failing due to inaccuracy with fees.

  0xJem

  committed
  b8d7fac

  Copy full SHA for b8d7fac

• Attempting to meet liquidity hurdle

  0xJem

  committed
  4856e92

  Copy full SHA for 4856e92

• Adjust default slippage in tests. Re-calculate quote tokens to deposit based on the updated base tokens available.

  0xJem

  committed
  ffd5592

  Copy full SHA for ffd5592

• Document behaviours

  0xJem

  committed
  e4d05be

  Copy full SHA for e4d05be

• Some tests passing

  0xJem

  committed
  af8a072

  Copy full SHA for af8a072

• Tweaks for decimals

  0xJem

  committed
  873d307

  Copy full SHA for 873d307

• Cleanup

  0xJem

  committed
  241f1dd

  Copy full SHA for 241f1dd

• Relax check on post-settlement base token balance

  0xJem

  committed
  f99c6f8

  Copy full SHA for f99c6f8

• Cleanup. Remove redundant tests. Add tests with a decimal price.

  0xJem

  committed
  12919f4

  Copy full SHA for 12919f4

• Simplify LP balance checks. Add check on LP price.

  0xJem

  committed
  5d7723d

  Copy full SHA for 5d7723d

Commits on Aug 5, 2024

• fix: simplify donate mitigation and handle donated but not synced tokens

  Oighty

  committed
  9330523

  Copy full SHA for 9330523

Commits on Aug 7, 2024

• Update docs, remove logging

  0xJem

  committed
  b4389a5

  Copy full SHA for b4389a5

• Amend fuzz tests to have donated quote token amounts up to an amount higher than the auction price

  0xJem

  committed
  f663c06

  Copy full SHA for f663c06

• Fix misleading comment

  0xJem

  committed
  7521cd6

  Copy full SHA for 7521cd6

• Rename proceedsUtilisationPercent to poolPercent to be consistent with the Baseline callback

  0xJem

  committed
  732a7a7

  Copy full SHA for 732a7a7

• Missed renaming of tests

  0xJem

  committed
  a97f345

  Copy full SHA for a97f345

• Adjust minimum poolPercent to 10%

  0xJem

  committed
  2f1e1b8

  Copy full SHA for 2f1e1b8

Commits on Aug 8, 2024

• fix: H-04, handle pre-initialized univ3 pool

  Oighty

  committed
  8b405e9

  Copy full SHA for 8b405e9

Commits on Aug 9, 2024

• Clear lib directory when doing full install

  0xJem

  committed
  2326cb2

  Copy full SHA for 2326cb2

• Send remaining tokens to the recipient, not the seller

  0xJem

  committed
  43c2363

  Copy full SHA for 43c2363

• Ensure that LP vesting start is after auction conclusion (L-03)

  0xJem

  committed
  8eeb8d6

  Copy full SHA for 8eeb8d6

Commits on Aug 12, 2024

• Test TODOs

  0xJem

  committed
  9e87c19

  Copy full SHA for 9e87c19

• Add tests for pools with higher/lower prices

  0xJem

  committed
  7f39a34

  Copy full SHA for 7f39a34

• chore: linting

  0xJem

  committed
  c4c7693

  Copy full SHA for c4c7693

• Remove redundant tests

  0xJem

  committed
  4f72f57

  Copy full SHA for 4f72f57

Commits on Aug 14, 2024

• Merge branch 'uniswap-dtl-fixes' into uniswap-v2-donate-and-sync

  Show description for dc871a5
  0xJem

  committed
  dc871a5

  Copy full SHA for dc871a5

• chore: update salts

  0xJem

  committed
  6231b52

  Copy full SHA for 6231b52

• Fix tests not accounting for donated quote tokens

  0xJem

  committed
  588f28f

  Copy full SHA for 588f28f

• Merge pull request #13 from Axis-Fi/uniswap-v2-donate-and-sync

  Show description for d0499ac
  0xJem

  authored
  d0499ac

  Copy full SHA for d0499ac

• Merge branch 'baseline-updates' into uniswap-dtl-fixes

  Show description for ad36ed9
  0xJem

  committed
  ad36ed9

  Copy full SHA for ad36ed9

• chore: update salts

  0xJem

  committed
  064978a

  Copy full SHA for 064978a

• Amend glob patterns for format/lint ignore lists

  0xJem

  committed
  2babe2f

  Copy full SHA for 2babe2f

• Linting due to change in default formatting with forge. Also updates salts.

  0xJem

  committed
  334ee63

  Copy full SHA for 334ee63