Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace server side metadata api with client side api #23

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

edmulraney
Copy link
Collaborator

@edmulraney edmulraney commented Feb 24, 2025

  • moves server app ipfs-api from fireworks into this repo
  • deletes metadata storage from ipfs-api
  • renames ipfs-api to curator-api since the server side only handles twitter authentication and followings for curator purposes
  • adds new SDK method (saveMetadata()) for uploading metadata (auction and curator) to IPFS using purely client side code (no server side logic for this anymore)
  • forces SDK tests to run in a browser (headless chrome) instead of node (the Fleek SDK browser dependency doesn't run in node (default test runner env))

@edmulraney edmulraney requested a review from wenfix February 24, 2025 13:59
@edmulraney edmulraney self-assigned this Feb 24, 2025
@wenfix
Copy link
Contributor

wenfix commented Feb 24, 2025

LGTM 🔥

@edmulraney edmulraney merged commit 56be50a into main Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants