Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vapix-sh: Add example that uses shellscript only and not C #310

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joakimr-axis
Copy link
Contributor

@joakimr-axis joakimr-axis commented Nov 26, 2024

Describe your changes

This example does the same thing as the VAPIX example written in C, but uses a POSIX shellscript to implement the application instead. It shows how simpler applications can be written with just a shellscript but still bring value, which is good for those who are not C-savvy. (Whereas those who want to build more advanced applications with VAPIX would probably opt for the C version to build upon.)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@joakimr-axis joakimr-axis requested a review from a team as a code owner November 26, 2024 15:10
@joakimr-axis joakimr-axis force-pushed the joakimr-axis_basicinfoshellscript branch 3 times, most recently from 6a543c9 to 9fc09e9 Compare November 26, 2024 15:14
This example does the same thing as the VAPIX example written in C, but
uses a POSIX shellscript to implement the application instead. It shows
how simpler applications can be written with just a shellscript but still
bring value, which is good for those who are not C-savvy. (Whereas those
who want to build more advanced applications with VAPIX would probably
opt for the C version to build upon.)

Change-Id: I6f0e874996e69e6319107931bbc93b81ffa40db9
Signed-off-by: Joakim Roubert <[email protected]>
@joakimr-axis joakimr-axis force-pushed the joakimr-axis_basicinfoshellscript branch from 9fc09e9 to fe3ce8d Compare November 26, 2024 15:16
Change-Id: I9c1635ae07dd943b09665f41753a33ffbbbfba73
Signed-off-by: Joakim Roubert <[email protected]>
Copy link
Contributor

@pataxis pataxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this need some more consideration to publish.

@joakimr-axis joakimr-axis force-pushed the joakimr-axis_basicinfoshellscript branch from 5953c24 to 9bb64b8 Compare November 27, 2024 07:39
As @apljungquist pointed out, this package has no architecture
dependencies and hence we should not build architecture-specific
versions.

Change-Id: I5b99c7af76b8e854299c18dff784feb4dafc82b7
Signed-off-by: Joakim Roubert <[email protected]>
@joakimr-axis joakimr-axis force-pushed the joakimr-axis_basicinfoshellscript branch from 9bb64b8 to 87731f8 Compare November 27, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants