Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step up gRPC version #88

Merged
merged 1 commit into from
Sep 12, 2024
Merged

step up gRPC version #88

merged 1 commit into from
Sep 12, 2024

Conversation

madelen-at-work
Copy link
Contributor

@madelen-at-work madelen-at-work commented Aug 26, 2024 •
edited
Loading

Describe your changes

Updated gRPC version to 1.65, mainly in order to get OpenSSL bump up to 3.0 which is required in able to run application on AXIS OS 12.0 and later.
The updates to build pipeline is heavily inspired by gRPCs C++ example for cross-compiling. Possibly we should look into migrating to cmake in the future for easier(?) upgrades.

Issue ticket number and link

  • Fixes issue where application was depending on OpenSSL 1.1.1

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@madelen-at-work madelen-at-work requested review from a team as code owners August 26, 2024 11:31
madelen-at-work
madelen-at-work commented Aug 30, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@madelen-at-work madelen-at-work force-pushed the step-up-grpc branch 6 times, most recently from 0c9de0b to d1bf9d9 Compare September 11, 2024 06:33
@madelen-at-work madelen-at-work force-pushed the step-up-grpc branch 2 times, most recently from 9e8fd6e to d23f9c1 Compare September 12, 2024 06:23
@madelen-at-work madelen-at-work merged commit 846553e into main Sep 12, 2024
13 checks passed
@madelen-at-work madelen-at-work deleted the step-up-grpc branch September 12, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killenheladagen killenheladagen killenheladagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madelen-at-work @killenheladagen