Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ACAP 4 Native SDK and libmodbus version 3.1.11 #44

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

joakimr-axis
Copy link
Contributor

@joakimr-axis joakimr-axis commented Oct 25, 2024

Describe your changes

This patchset moves to the ACAP 4 Native SDK. This means we drop support for (really) old devices. If you need to build with the ACAP 3 SDK for old devices, please use the previous commit as your base since that will work fine for that.

With the move to ACAP 4 Native SDK, we can drop the support for this repo to be built with locally installed SDKs (that nobody uses these days anyway) and then move the build of libmodbus from Makefile into the Dockerfile instead.

This patchset also bumps libmodbus from version 3.1.7 to 3.1.11.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

This patchset moves to the ACAP 4 Native SDK. This means we drop
support for (really) old devices. If you need to build with the ACAP 3
SDK for old devices, please use the previous commit as your base since
that will work fine for that.

With the move to ACAP 4 Native SDK, we can drop the support for this
repo to be built with locally installed SDKs (that nobody uses these
days anyway) and then move the build of libmodbus from Makefile into the
Dockerfile instead.

This patchset also bumps libmodbus from version 3.1.7 to 3.1.11.

Change-Id: I9cfef8b6608c4c8ab897034799b54f8e2aae6fab
Signed-off-by: Joakim Roubert <[email protected]>
Change-Id: I66136fbda91d6a3c7eb6fb853d140d4737349e4f
Signed-off-by: Joakim Roubert <[email protected]>
@joakimr-axis joakimr-axis force-pushed the joakimr-axis_bumpmodbus branch from 53295b5 to 41d4180 Compare October 25, 2024 09:23
Change-Id: I57e6ef793f78b0267ae4fa4a18637951133fb169
Signed-off-by: Joakim Roubert <[email protected]>
@joakimr-axis joakimr-axis force-pushed the joakimr-axis_bumpmodbus branch from 41d4180 to 1769a71 Compare October 25, 2024 09:30
@joakimr-axis joakimr-axis merged commit 9515874 into main Oct 25, 2024
8 checks passed
@joakimr-axis joakimr-axis deleted the joakimr-axis_bumpmodbus branch October 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant