chore: remove biome lint rule noEmptyInterface

AxisCommunications · Oct 3, 2023 · 89c9afd · 89c9afd
1 parent 4505b80
commit 89c9afd
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 17 deletions.
diff --git a/biome.json b/biome.json
@@ -8,7 +8,6 @@
 		"rules": {
 			"recommended": true,
 			"suspicious": {
-				"noEmptyInterface": "off",
 				"noArrayIndexKey": "off"
 			},
 			"a11y": {

diff --git a/packages/core/src/Input/Input.tsx b/packages/core/src/Input/Input.tsx
@@ -462,12 +462,12 @@ function Input<T extends string | NumberInputType>({
 	)
 }
 
-export interface TextInputProps extends BaseInputProps<string> {}
+export type TextInputProps = BaseInputProps<string>
 export const TextInput: FC<TextInputProps> = props => (
 	<Input {...props} type="text" />
 )
 
-export interface NumberInputProps extends BaseInputProps<NumberInputType> {}
+export type NumberInputProps = BaseInputProps<NumberInputType>
 export const NumberInput: FC<NumberInputProps> = props => (
 	<Input {...props} type="number" />
 )

diff --git a/packages/core/src/Input/TimeInput.tsx b/packages/core/src/Input/TimeInput.tsx
@@ -217,17 +217,16 @@ const getKeyCodeValue = (key: string) => {
 	}
 }
 
-export interface BaseTimeInputProps
-	extends Omit<
-		TextInputProps,
-		| 'value'
-		| 'onValueChange'
-		| 'onChange'
-		| 'ref'
-		| 'width'
-		| 'maxLength'
-		| 'placeholder'
-	> {}
+export type BaseTimeInputProps = Omit<
+	TextInputProps,
+	| 'value'
+	| 'onValueChange'
+	| 'onChange'
+	| 'ref'
+	| 'width'
+	| 'maxLength'
+	| 'placeholder'
+>
 
 export interface TimeInputValues {
 	readonly hour?: number

diff --git a/packages/core/types/styled-components.d.ts b/packages/core/types/styled-components.d.ts
@@ -4,5 +4,6 @@ import { Theme } from '../src/theme'
 
 // and extend them!
 declare module 'styled-components' {
+	// biome-ignore lint/suspicious/noEmptyInterface: used to import from styled-components
 	export interface DefaultTheme extends Theme {}
 }
diff --git a/packages/docs/src/types.ts b/packages/docs/src/types.ts
@@ -23,7 +23,7 @@ export interface ComponentDoc {
 	readonly props: Props
 }
 
-export interface Props extends StringIndexedObject<PropItem> {}
+export type Props = StringIndexedObject<PropItem>
 
 export interface PropItem {
 	readonly name: string

diff --git a/packages/docs/types/styled-components.d.ts b/packages/docs/types/styled-components.d.ts
@@ -4,5 +4,5 @@ import { Theme } from 'practical-react-components-core'
 
 // and extend them!
 declare module 'styled-components' {
-	export interface DefaultTheme extends Theme {}
+	export type DefaultTheme = Theme
 }
diff --git a/packages/ui-tests/types/styled-components.d.ts b/packages/ui-tests/types/styled-components.d.ts
@@ -4,5 +4,5 @@ import { Theme } from 'practical-react-components-core'
 
 // and extend them!
 declare module 'styled-components' {
-	export interface DefaultTheme extends Theme {}
+	export type DefaultTheme = Theme
 }