chore: remove biome lint rule noAssignInExpressions

AxisCommunications · Oct 3, 2023 · bb8059f · bb8059f
1 parent 0073edf
commit bb8059f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/biome.json b/biome.json
@@ -11,8 +11,7 @@
 				"noEmptyInterface": "off",
 				"noExplicitAny": "off",
 				"noArrayIndexKey": "off",
-				"noShadowRestrictedNames": "off",
-				"noAssignInExpressions": "off"
+				"noShadowRestrictedNames": "off"
 			},
 			"a11y": {
 				"noSvgWithoutTitle": "off"

diff --git a/packages/docs/src/Menu.tsx b/packages/docs/src/Menu.tsx
@@ -97,10 +97,14 @@ export const Menu: FC<MenuProps> = ({ components }) => {
 				label: c.name,
 				icon: () => c.icon ?? null,
 				selected: matchPath(location.pathname, c.route) !== null,
-				onClick: () =>
-					/^https?:\/\//.test(c.route)
-						? (window.location.href = c.route)
-						: selectTab(c.route),
+				onClick: () => {
+					const routeMatches = /^https?:\/\//.test(c.route)
+					if (routeMatches) {
+						window.location.href = c.route
+						return
+					}
+					selectTab(c.route)
+				},
 				...c,
 			})) as unknown as ReadonlyArray<ComponentGroup>,
 		[location.pathname, components, selectTab]

diff --git a/packages/ui-tests/src/Menu.tsx b/packages/ui-tests/src/Menu.tsx
@@ -79,10 +79,14 @@ export const Menu: FC<MenuProps> = ({ components }) => {
 				label: c.name,
 				icon: () => null,
 				selected: c.route === location.pathname,
-				onClick: () =>
-					/^https?:\/\//.test(c.route)
-						? (window.location.href = c.route)
-						: selectTab(c.route),
+				onClick: () => {
+					const routeMatches = /^https?:\/\//.test(c.route)
+					if (routeMatches) {
+						window.location.href = c.route
+						return
+					}
+					selectTab(c.route)
+				},
 				...c,
 			})) as unknown as ReadonlyArray<ComponentGroup>,
 		[location.pathname, components, selectTab]