Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): hide tooltip when touched outside of a component #277

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

HitomiWin
Copy link
Contributor

Fixes: #276

Describe your changes

Imported useClickOutside from 'react-hooks-shareable' and added it to onPointerDown event.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@danielkaxis
Copy link
Collaborator

We break current behaviour with this implementation. On mobile devices when the user scrolls, the user could scroll for a small distance before the tooltip disappeared. The motivation for this was that when you are using a mobile device you touch the phone all the time and the tooltip would just disappear. We should discuss this further on how to do.

@AxisCommunications AxisCommunications deleted a comment from HitomiWin Sep 1, 2023
@HitomiWin HitomiWin force-pushed the fix-tooltip-5635 branch 2 times, most recently from 5406ab6 to 8b3b641 Compare September 25, 2023 14:45
@danielkaxis danielkaxis merged commit 7c3a669 into AxisCommunications:main Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips are stuck on touchscreen
2 participants