[#307] Axon plugin gives false highlights about non existing properties when they are defined in a superclass #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid false positives // improved test assertions so failures are detected.
smcvb
changed the title
smcvb
approved these changes
Oct 14, 2024
|
@CodeDrivenMitch, I think what @guymahieu provided is fine. Would you mind giving your opinion as well? |
CodeDrivenMitch
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we get warnings on SagaEventHandlers that rely on an associationProperty from a superclass of the messsage. This works in Axon but is indicated as a problem by the plugin.
This PR fixes that for the SagaEventHandlers, but there are probably other cases where this applies (routingKeys?). We do not have this case in our project at the moment, so I did not change that.
This pull request resolves #307.