Auto start Axon Server tenant components #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.6.0 to 3.6.2. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.6.0...maven-javadoc-plugin-3.6.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…e.maven.plugins-maven-javadoc-plugin-3.6.2 Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.0 to 3.6.2
smcvb
reviewed
Nov 16, 2023
...xonframework/extensions/multitenancy/autoconfig/MultiTenancyAxonServerAutoConfiguration.java
Outdated
Show resolved
Hide resolved
smcvb
reviewed
Nov 16, 2023
...xonframework/extensions/multitenancy/autoconfig/MultiTenancyAxonServerAutoConfiguration.java
Show resolved
Hide resolved
…trieving the MultiTenantEventProcessorControlService from a Component. Due to this, its lifecycle methods should be invoked.
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
approved these changes
Nov 22, 2023
smcvb
added a commit
that referenced
this pull request
Nov 22, 2023
Add start-notice to all segment factory interfaces #160
smcvb
added a commit
that referenced
this pull request
Nov 22, 2023
Expand samples slightly, by using the markdown code block syntax, with classes in them, adding comments when applicable. #160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is rather simple; just start Axon Server components when the factory produces them.
Timing is always safe, as factory involvement will happen only after the main MultiTenant component is registered to configuration and ready to use.
Unfortunately, it is not possible to write a test as component is created inside factory method, therefore it is not mockable.
Also none of produce components exposes something like isStarted() method where we could check if start was invoked.
Passed manual testing.