Skip to content

Commit

Permalink
[Warlock] Sataiel's Volition (simulationcraft#9205)
Browse files Browse the repository at this point in the history
  • Loading branch information
Azevara authored Aug 9, 2024
1 parent a075848 commit 78f94c7
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
11 changes: 11 additions & 0 deletions engine/class_modules/warlock/sc_warlock_actions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,9 @@ using namespace helpers;
base_td_multiplier *= 1.0 + p->talents.kindled_malice->effectN( 3 ).percent();
base_td_multiplier *= 1.0 + p->talents.sacrolashs_dark_strike->effectN( 1 ).percent();

if ( soul_harvester() && p->hero.sataiels_volition.ok() )
base_tick_time *= 1.0 + p->hero.sataiels_volition->effectN( 1 ).percent();

triggers.ravenous_afflictions = p->talents.ravenous_afflictions.ok();

affected_by.deaths_embrace = p->talents.deaths_embrace.ok();
Expand Down Expand Up @@ -2168,6 +2171,14 @@ using namespace helpers;
return m;
}

void execute() override
{
warlock_spell_t::execute();

if ( soul_harvester() && p()->hero.sataiels_volition.ok() )
p()->buffs.nightfall->trigger();
}

void impact( action_state_t* s ) override
{
warlock_spell_t::impact( s );
Expand Down
2 changes: 2 additions & 0 deletions engine/class_modules/warlock/sc_warlock_init.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,8 @@ namespace warlock
hero.wicked_reaping_dmg = find_spell( 449826 );

hero.quietus = find_talent_spell( talent_tree::HERO, "Quietus" ); // Should be ID 449634

hero.sataiels_volition = find_talent_spell( talent_tree::HERO, "Sataiel's Volition" ); // Should be ID 449637
}

void warlock_t::init_base_stats()
Expand Down
13 changes: 13 additions & 0 deletions engine/class_modules/warlock/sc_warlock_pets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,16 @@ struct fel_firebolt_t : public warlock_pet_spell_t

return m;
}

double composite_da_multiplier( const action_state_t* s ) const override
{
double m = warlock_pet_spell_t::composite_da_multiplier( s );

if ( p()->o()->hero.sataiels_volition.ok() )
m *= 1.0 + p()->o()->hero.sataiels_volition->effectN( 2 ).percent();

return m;
}
};

void wild_imp_pet_t::create_actions()
Expand Down Expand Up @@ -1199,6 +1209,9 @@ void wild_imp_pet_t::demise()
{
double core_chance = o()->talents.demonic_core_spell->effectN( 1 ).percent();

if ( imploded )
core_chance += o()->hero.sataiels_volition->effectN( 3 ).percent();

if ( !o()->talents.demoniac.ok() )
core_chance = 0.0;

Expand Down

0 comments on commit 78f94c7

Please sign in to comment.