Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all dependencies to their latest versions + merged winit_input_helper directly into this library. #74

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

rydb
Copy link
Contributor

@rydb rydb commented Oct 14, 2024

This pr contains two changes:

  1. All dependencies are now updated to their latest versions.

There are two warnings now for using deprecated functions in winit, but I couldn't figure out how to get those updated for winit 0.30, so I just used those for expediency.

  1. merged winit_input_helper directly into this lib.

winit_input_helper is only a few hundred lines long, has no dependencies other then winit, and it is currently abandoned as far as I can tell, but it was the sole blocker of updating winit. I just merged the two files it uses into this project, so that when winit/wgpu updates again, it will no longer be a blocker as it was before.

@Azkellas
Copy link
Owner

Thanks for the pr. I wanted to wait until all the dependency chain winit-wgpu-egui-... was resolved but it has been pending for way too long because of the new api in winit 0.30 and winit-input-helper stalling.
I think we can vendor the helper in the meantime.

I'm surprised you managed to update to winit 0.30 while keeping the current event loop though. I think it would be better to migrate to the new ApplicationHandler API to keep this project idiomatic and up-to-date (while also cleaning the dreadful runner).
I recently implemented it in my own project (which used this project as template), though I haven't tested it on wasm. winit-input-helper has a pending PR to support it that we can vendor instead of the main repo.

Would you like to try it out? Otherwise I can probably work on it this week-end.

Thanks for the help!

@rydb
Copy link
Contributor Author

rydb commented Oct 15, 2024

Thanks for the pr. I wanted to wait until all the dependency chain winit-wgpu-egui-... was resolved but it has been pending for way too long because of the new api in winit 0.30 and winit-input-helper stalling. I think we can vendor the helper in the meantime.

I'm surprised you managed to update to winit 0.30 while keeping the current event loop though. I think it would be better to migrate to the new ApplicationHandler API to keep this project idiomatic and up-to-date (while also cleaning the dreadful runner). I recently implemented it in my own project (which used this project as template), though I haven't tested it on wasm. winit-input-helper has a pending PR to support it that we can vendor instead of the main repo.

Would you like to try it out? Otherwise I can probably work on it this week-end.

Thanks for the help!

which project?

@Azkellas
Copy link
Owner

Sadly it's closed source (and diverged too much to be comparable), but examples in the winit input helper PR I linked above could serve as a good reference point too.

@rydb
Copy link
Contributor Author

rydb commented Oct 15, 2024

fixed WASM import. CI should pass now.

@Azkellas
Copy link
Owner

I had a go at using the new winit api. No issue for native and rust hot reload, but getting it to work in wasm is a bit tricky.
I'll do it in a separate pull request I think.

@Azkellas Azkellas merged commit 21bf07a into Azkellas:main Oct 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants