fix: Incorrect macro usage and redundant boolean comparison #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rust,
assert!
is a macro and must be called with an exclamation mark and a condition inside the parentheses. Usingassert(condition)
without the exclamation mark will result in a compilation error, asassert
does not exist as a function. Without fixing this, the program will not compile.Redundant
== true
Check: The functionvalid_fn
already returns a boolean value (bool
). When a function already returns a boolean value (bool
), an additional comparison withtrue
orfalse
is redundant and reduces code readability.