Respond to review

AztecProtocol · Nov 15, 2024 · e04aeab · e04aeab
1 parent 3d276dd
commit e04aeab
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/.../cpp/src/barretenberg/plonk_honk_shared/execution_trace/execution_trace_usage_tracker.hpp b/.../cpp/src/barretenberg/plonk_honk_shared/execution_trace/execution_trace_usage_tracker.hpp
@@ -38,7 +38,6 @@ struct ExecutionTraceUsageTracker {
         }
 
         if (trace_settings.structure) {
-            info("yes trace structure");
             fixed_sizes.set_fixed_block_sizes(trace_settings);
         }
 

diff --git a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp
@@ -74,7 +74,7 @@ struct TraceSettings {
     uint32_t overflow_capacity = 0;
 };
 
-class MegaTraceBlock : public ExecutionTraceBlock<fr, 4, 14> {
+class MegaTraceBlock : public ExecutionTraceBlock<fr, /*NUM_WIRES_ */ 4, /*NUM_SELECTORS_*/ 14> {
     using SelectorType = ExecutionTraceBlock<fr, 4, 14>::SelectorType;
 
   public:
@@ -262,8 +262,8 @@ static constexpr TraceStructure SMALL_TEST_STRUCTURE{ .ecc_op = 1 << 14,
                                                       .overflow = 0 };
 
 /**
- * @brief A minimal structuring specifically tailored to the medium complexity transaction for the Cli: MentIVC
- * benchmark
+ * @brief A minimal structuring specifically tailored to the medium complexity transaction of the Client IVC
+ * benchmark.
  */
 static constexpr TraceStructure CLIENT_IVC_BENCH_STRUCTURE{ .ecc_op = 1 << 10,
                                                             .pub_inputs = 1 << 7,

diff --git a/...etenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp b/...etenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp
@@ -39,7 +39,7 @@ template <typename T> struct UltraTraceBlockData {
     bool operator==(const UltraTraceBlockData& other) const = default;
 };
 
-class UltraTraceBlock : public ExecutionTraceBlock<fr, 4, 13> {
+class UltraTraceBlock : public ExecutionTraceBlock<fr, /*NUM_WIRES_ */ 4, /*NUM_SELECTORS_*/ 13> {
     using SelectorType = ExecutionTraceBlock<fr, 4, 13>::SelectorType;
 
   public:

diff --git a/barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp b/barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp
@@ -374,7 +374,7 @@ Accumulator ECCVMSetRelationImpl<FF>::compute_grand_product_denominator(const Al
 }
 
 /**
- * @brief Expression for the StandardExecutionTracemetic gate.
+ * @brief Expression for the standard arithmetic gate.
  * @dbetails The relation is defined as C(in(X)...) =
  *    (q_m * w_r * w_l) + (q_l * w_l) + (q_r * w_r) + (q_o * w_o) + q_c
  *