-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cl/ci3.2 #10919
Open
charlielye
wants to merge
19
commits into
master
Choose a base branch
from
cl/ci3.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: Cl/ci3.2 #10919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constraints thing.
…GRUMPKIN_CRS_PATH.
charlielye
requested review from
jeanmon,
IlyasRidhuan and
fcarreiro
as code owners
December 20, 2024 21:20
ludamad
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further iteration towards full CI3.
TLDR: Working towards ~10m repo test time.
test-cmds
cmd on bootstrap scripts. Returns a list of commands, that if run from repo root, execute individual (usually) tests../scripts/run_test.sh
being a script that given some succinct arguments, can run a single test.test-all
(eventually to become justtest
) in root bootstrap.sh. No args runs all tests, or you can give it a list of folders to projects with their own bootstrap scripts and it'll run their tests. Runs in 10m20s. Currently skipping some things (see TODO below). Reports slow tests after run.TEST=0/1
flag. Unnecessary. Normal bootstraps don't run tests, and If i request to run tests I want them to run. So the "skip tests if cache flag exists" only needs to be applied ifCI=1
.bootstrap
folder. Is was there to help test the bootstrap script in CI, but now we use the bootstrap script in CI.boxes
.TODO:
test_caches_open|requests
in noir tests.