Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 7 bit long note_type_id #10951

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: 7 bit long note_type_id #10951

wants to merge 3 commits into from

Conversation

benesjan
Copy link
Contributor

Making note type id 7 bits long.

@benesjan Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan mentioned this pull request Dec 23, 2024
Closed
@benesjan benesjan changed the title feat: 7 bit long note type id feat: 7 bit long note_type_id Dec 23, 2024
@benesjan benesjan mentioned this pull request Dec 23, 2024
Open
@benesjan benesjan force-pushed the 12-23-feat_7_bit_long_note_type_id branch from 9ea4e28 to dc769f2 Compare December 23, 2024 21:08
@benesjan benesjan marked this pull request as ready for review December 23, 2024 21:21
nventuro
nventuro reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's also add noir tests in which we check the note type id allocation - take a look at how I tested storage slot allocation in #10320 for inspiration

yarn-project/foundation/src/abi/note_selector.ts Outdated Show resolved Hide resolved
@benesjan benesjan marked this pull request as draft December 24, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro left review comments

@sklppy88 sklppy88 Awaiting requested review from sklppy88

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benesjan @nventuro