refactor: Simplify port forwarding and process management in kind tests #12393
+193
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd tests This change updates the port forwarding utility to dynamically allocate ports and improve process management across multiple end-to-end tests. Key modifications include: - Removing hardcoded host port configurations - Dynamically allocating ports during port forwarding - Centralizing process tracking with a `forwardProcesses` array - Adding `afterAll` hooks to kill port forward processes - Improving error handling and logging in port forward utility The refactoring simplifies test setup and ensures proper cleanup of network resources across various Spartan test scenarios.
just-mitch
changed the title
alexghr
approved these changes
Mar 3, 2025
just-mitch
deleted the
12367-bugflake-method-not-found-pxe_getnodeinfo-in-kind-ci-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the port forwarding utility to dynamically allocate ports and improve process management across multiple end-to-end tests. Key modifications include:
forwardProcessesarrayafterAllhooks to kill port forward processesThe root cause was discovered by @spalladino. The time between a port being assigned in bash and then it being used was causing mismatches: two different services were trying to use the same port.
Also, not cleaning up ports behind ourselves was causing there to be an artificially low pool of ports to choose from.