feat: IPA Accumulator in Builder #9846

lucasxia01 · 2024-11-08T16:01:29Z

Adds IPA claim to builder, pk, vk, so that the verifier knows where to look to extract the IPA claim from. Modifies the UltraRecursiveVerifier to extract out the IPA claim from the public inputs and returns it

…builder

lucasxia01 · 2024-11-15T23:35:58Z

barretenberg/cpp/src/barretenberg/commitment_schemes/claim.hpp

+                 opening_pair.challenge.binary_basis_limbs[1].element.normalize().witness_index,
+                 opening_pair.challenge.binary_basis_limbs[2].element.normalize().witness_index,
+                 opening_pair.challenge.binary_basis_limbs[3].element.normalize().witness_index,
+                 //  opening_pair.evaluation.binary_basis_limbs[0].element.normalize().witness_index,


the evaluation is always 0 for our case I believe, so it doesn't have any witness indices

lucasxia01 · 2024-11-15T23:36:32Z

barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp

@@ -749,20 +749,21 @@ template <typename Curve_> class IPA {
    }

    /**
-     * @brief Takes two IPA claims and accumulates them into 1 IPA claim.
-     * @details We create an IPA accumulator by running the IPA recursive verifier on each claim. Then, we generate challenges, and use these challenges to compute the new accumulator. We also create the accumulated polynomial. 
+     * @brief Takes two IPA claims and accumulates them into 1 IPA claim. Also computes IPA proof for the claim.


modified so that accumulate just returns the IPA proof directly

lucasxia01 · 2024-11-15T23:39:07Z

barretenberg/cpp/src/barretenberg/examples/join_split/join_split.test.cpp

@@ -33,8 +33,8 @@ using namespace bb::join_split_example::proofs::notes::native;
 using key_pair = join_split_example::fixtures::grumpkin_key_pair;

 auto create_account_leaf_data(fr const& account_alias_hash,
-                              grumpkin::g1::affine_element const& owner_key,
-                              grumpkin::g1::affine_element const& signing_key)
+                              bb::grumpkin::g1::affine_element const& owner_key,


had to add namespace stuff to avoid ambiguous errors...

lucasxia01 · 2024-11-15T23:40:12Z

barretenberg/cpp/src/barretenberg/flavor/flavor.hpp

@@ -379,6 +379,9 @@ MegaZKRecursiveFlavor_<UltraCircuitBuilder>>;
 template <typename T>
 concept HasDataBus = IsMegaFlavor<T>;

+template <typename T>
+concept DoesRecursiveIPA = IsAnyOf<T, UltraFlavor, UltraFlavorWithZK>;


not ultra keccak because that will only be called on the root rollup circuit which will just verify the IPA claim.

lucasxia01 · 2024-11-15T23:40:42Z

...nberg/cpp/src/barretenberg/stdlib/client_ivc_verifier/client_ivc_recursive_verifier.test.cpp

    tube_builder->add_pairing_point_accumulator(
        stdlib::recursion::init_default_agg_obj_indices<Builder>(*tube_builder));
+    // The tube only calls an IPA recursive verifier once, so we can just add this IPA claim and proof


for the tube circuit, add the IPA claim

lucasxia01 · 2024-11-15T23:41:09Z

barretenberg/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.test.cpp

-using byte_array_ct = byte_array<Builder>;
-using field_ct = field_t<Builder>;
-using witness_ct = witness_t<Builder>;
+using bool_ct = stdlib::bool_t<Builder>;


namespace changes for some reason.. maybe because of extra includes

lucasxia01 · 2024-11-15T23:42:21Z

barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.test.cpp


-    EXPECT_DEBUG_DEATH(verifier.verify(proof), "(ipa_relation.get_value.* == -opening_claim.commitment.get_value.*)");
+    static_cast<void>(goblin_rec_verifier_output);


the proper fix here is to run a IPA verifier on the claim to check it, which should fail.

lucasxia01 · 2024-11-15T23:43:03Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_builder_base.hpp

    bool contains_pairing_point_accumulator = false;

+    // Public input indices which contain the output IPA opening claim


adding the IPA claim public inputs to the builder

lucasxia01 · 2024-11-15T23:43:33Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_builder_base.hpp

+    IPAClaimPubInputIndices ipa_claim_public_input_indices;
+    bool contains_ipa_claim = false;
+
+    uint32_t ipa_verifier_count = 0;


will delete this since the builder will not keep track of this

lucasxia01 · 2024-11-15T23:44:27Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/flavor_serialization.test.cpp

@@ -47,6 +47,11 @@ TYPED_TEST(FlavorSerializationTests, VerificationKeySerialization)
    // Set the pcs ptr to null since this will not be reconstructed correctly from buffer
    original_vkey.pcs_verification_key = nullptr;

+    // probably not needed


could probably delete this

lucasxia01 · 2024-11-15T23:44:52Z

barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp

@@ -307,12 +307,17 @@ template <IsHonkFlavor Flavor> class DeciderProvingKey_ {
            proving_key.public_inputs.emplace_back(proving_key.polynomials.w_r[idx]);
        }

-        // Set the recursive proof indices
+        if constexpr (DoesRecursiveIPA<Flavor>) { // Set the IPA claim indices


copies the ipa stuff over to the proving key from the builder

lucasxia01 · 2024-11-15T23:45:21Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_flavor.hpp

        bool operator==(const VerificationKey&) const = default;
        VerificationKey() = default;
        VerificationKey(const size_t circuit_size, const size_t num_public_inputs)
            : VerificationKey_(circuit_size, num_public_inputs)
        {}
        VerificationKey(ProvingKey& proving_key)
+            : contains_ipa_claim(proving_key.contains_ipa_claim)


copies the proving key ipa stuff to the vk

initial builder object

4b2f1cd

lucasxia01 self-assigned this Nov 8, 2024

lucasxia01 added 7 commits November 12, 2024 19:00

rename

3a6bdad

return unfinished transcript

ed12d5b

ipa claim indices

b948683

add ipa claim to public inputs upon accumulation

beb03a4

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

39b0b76

…builder

fix build

20a6933

adding ipa claim to proving/verification keys

b3ebdeb

lucasxia01 marked this pull request as ready for review November 14, 2024 00:53

lucasxia01 added 8 commits November 14, 2024 18:38

fix build

98e8018

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

87163af

…builder

fix some random tests with namespace ambiguity issues

f1a429d

fix serialization

c86252b

fix test

cb40e08

modify eccvm verify_proof

68e8acb

make accumulate also generate the ipa proof

3c83148

add ipa claim/proof to tube

ee98551

lucasxia01 requested review from jeanmon, IlyasRidhuan and fcarreiro as code owners November 15, 2024 22:56

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

113ba04

…builder

lucasxia01 commented Nov 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: IPA Accumulator in Builder #9846

feat: IPA Accumulator in Builder #9846

lucasxia01 commented Nov 8, 2024 •

edited

Loading

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024 •

edited

Loading

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024


		EXPECT_DEBUG_DEATH(verifier.verify(proof), "(ipa_relation.get_value.* == -opening_claim.commitment.get_value.*)");
		static_cast<void>(goblin_rec_verifier_output);

		bool contains_pairing_point_accumulator = false;

		// Public input indices which contain the output IPA opening claim

feat: IPA Accumulator in Builder #9846

Are you sure you want to change the base?

feat: IPA Accumulator in Builder #9846

Conversation

lucasxia01 commented Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasxia01 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasxia01 commented Nov 8, 2024 •

edited

Loading

lucasxia01 Nov 15, 2024 •

edited

Loading