Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set keccak var inputs to 0 after requested length #646

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guipublic
Copy link
Contributor

Description

Resolve noir issue reported here: noir-lang/noir#1934

For variable keccak input, we zero the inputs that are after the requested length.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@guipublic guipublic changed the title Set keccak var inputs to 0 after requested length fix: Set keccak var inputs to 0 after requested length Aug 1, 2023
@ludamad
Copy link
Collaborator

ludamad commented Aug 8, 2023

Note, the preferred way to merge this now is to use https://github.com/AztecProtocol/aztec-packages/blob/master/scripts/migrate_barretenberg_branch.sh from aztec packages repo and migrate the PR there when done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants