-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agents api - Add backend plumbing for agent manager #30
Agents api - Add backend plumbing for agent manager #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- app/api/main.py: Evaluated as low risk
- app/api/routers/agents.py: Evaluated as low risk
- app/api/config/config.py: Evaluated as low risk
Comments suppressed due to low confidence (4)
app/api/database/agents_repository.py:14
- The get_agent_by_name_and_type method should return a single agent instead of a list of agents.
async def get_agent_by_name_and_type(self, name: str, type: str) -> Agent:
app/api/database/agents_repository.py:68
- The update_agent method should have a return type of Agent instead of None.
async def update_agent(self, agent_id: str, fields: Dict[str, Any]) -> None:
app/api/database/agents_repository.py:85
- [nitpick] The error message 'Agent {agent_id} not found' could be more descriptive.
raise ValueError(f"Agent {agent_id} not found.")
app/api/database/db_client.py:104
- [nitpick] Verify if using 'item_id' for both 'item' and 'partition_key' is the intended behavior.
self.container.delete_item(item=item_id, partition_key=item_id)
Fixes part of #20
Description:
Need API end points for CRUD operations with server side validation.
Changes:
Next:
Test: