Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql sample updated #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mysql sample updated #50

wants to merge 1 commit into from

Conversation

zikalino
Copy link

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

How to Test

  • Install ansible
$ pip install ansible[azure]
  • [Optional] Install ansible role
$ ansible-galaxy install Azure.azure_preview_modules
$ pip install -r ~/.ansible/roles/Azure.azure_preview_modules/files/requirements-azure.txt
  • Get the sample playbook
git clone https://github.com/Azure-Samples/ansible-playbooks.git
cd ansible-playbooks
git checkout [branch-name]
  • Test the code
ansible-playbook <filename>.yml

What to Check

Verify that the playbook is successfully run.

Other Information

@ansibleazurebot ansibleazurebot mentioned this pull request Sep 23, 2018
Open
@kyliel
Copy link
Contributor

kyliel commented Sep 23, 2018

Below description is not correct.
This playbook create a MySQL server and an instance of MySQL Database,

@zikalino
Copy link
Author

@kyliel thanks! I will fix it

yungezz
yungezz reviewed Sep 26, 2018
View reviewed changes
mysql_access.yml
---
- hosts: localhost
vars:
resource_group: zimspostgresrg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to myTestResourceGroup

mysql_create.yml
@@ -14,7 +14,7 @@
#roles:
# - Azure.azure_preview_modules
vars:
resource_group: "{{ resource_group_name }}"
resource_group: zimspostgresrg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rename resource group

mysql_create.yml
@@ -31,8 +31,8 @@
resource_group: "{{ resource_group }}"
name: "{{ mysqlserver_name }}"
sku:
name: GP_Gen4_2
tier: GeneralPurpose
name: B_Gen5_1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one is cheaper? pls use cheapest one

@Fred-sun
Copy link
Contributor

@zikalino

@Fred-sun
Copy link
Contributor

Fred-sun commented Oct 9, 2018

@zikalino, reviewers request change, Thanks!

@Fred-sun
Copy link
Contributor

@zikalino Could you give a changed according by @yungezz's comment? Thanks!

@Fred-sun
Copy link
Contributor

@zikalino

@Fred-sun
Copy link
Contributor

@zikalino need you update

@Fred-sun
Copy link
Contributor

Fred-sun commented Dec 6, 2018

kindly ping

@Fred-sun
Copy link
Contributor

@zikalino need you udpate

@Fred-sun
Copy link
Contributor

Fred-sun commented Jan 3, 2019

@zikalino Please help take a look this when you're available and push for merged. Thanks!

@Fred-sun
Copy link
Contributor

@zikalino Please take a look this when you're available! Thanks!

@Fred-sun
Copy link
Contributor

@zikalino Please help take a look this PR when you're available! Thanks!

@Fred-sun
Copy link
Contributor

@zikalino

@Fred-sun
Copy link
Contributor

Fred-sun commented Mar 4, 2019

kindly ping

@Fred-sun
Copy link
Contributor

@zikalino @zikalino Please change this PR according by above comments? Thanks!

@Fred-sun
Copy link
Contributor

Fred-sun commented Apr 8, 2019

@zikalino

@Fred-sun
Copy link
Contributor

@zikalino Please update the PR according by the above comment? Push this to review! Thank you very much!

@Fred-sun
Copy link
Contributor

@zikalino need you changed! Thanks a lot!

@Fred-sun
Copy link
Contributor

@zikalino

@Fred-sun
Copy link
Contributor

@zikalino Need you to change! Please update when you're free! Thank you very much!

Fred-sun
Fred-sun reviewed Jul 15, 2019
View reviewed changes
mysql_access.yml

---
- hosts: localhost
vars:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the definition variable 'admin_password'.

@Fred-sun
Copy link
Contributor

@zikalino This PR has been open for a long time, please follow the comments to change and promote the review. Thank you very much!

@Fred-sun
Copy link
Contributor

Fred-sun commented Sep 3, 2019

@zikalino How will this PR be handled? hasn't been updated in a long time. Please check, thank you very much!

@Fred-sun
Copy link
Contributor

@zikalino Please help finish PR changed and push for review when you're free! Thanks a lot!

@Fred-sun
Copy link
Contributor

@zikalino Please help update this PR when you're free! Thank you very much!

@Fred-sun
Copy link
Contributor

kindly ping

@Fred-sun
Copy link
Contributor

@zikalino Can you help complete the change of PR and promote the merger? It's been around for a long time--Not much to change!. Thank you very much!

@Fred-sun
Copy link
Contributor

@zikalino Thank you for taking the time to contribute to this PR. We will transfer ansible 's azure module related Issue and PR to azure collection (https://github.com/ansible-collections/azure/pulls), can you transfer the Issue to azure collection repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fred-sun Fred-sun Fred-sun left review comments

@yungezz yungezz yungezz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zikalino @kyliel @Fred-sun @yungezz