Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GlobalStandard as default deployment sku for gpt-4o #2030

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hund030
Copy link

@hund030 hund030 commented Oct 9, 2024

Purpose

This PR is proposed to configure the GlobalStandard as the default deployment sku for the GPT-4o model.
GPT35-turbo and embedding remains Standard since they are not supported by the GlobalStandard sku.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox
Copy link
Collaborator

We already have a PR for a similar change, so I'm going to review that PR first.

@anfibiacreativa
Copy link
Member

According to @hund030 the other PR does not configure the SKU as default deployment. Looking forward to your comments, since this will be the base for supporting documentation for other template authors, going forward.

@pamelafox
Copy link
Collaborator

@pamelafox
Copy link
Collaborator

Also, we did implement this PR here:
https://github.com/Azure-Samples/openai-chat-app-quickstart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants