Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle null speech URLs with fallback to empty string #2158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle null speech URLs with fallback to empty string #2158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/frontend/src/components/Answer/SpeechOutputAzure.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const SpeechOutputAzure = ({ answer, speechConfig, index, isStreaming }:
return;
}
if (speechConfig.speechUrls[index]) {
playAudio(speechConfig.speechUrls[index]);
playAudio(speechConfig.speechUrls[index] ?? "");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

playAudio doesn't seem to have a special check for empty string, besides the catch expression. Does this end up being handled by that catch? Did you find it was better to do this than to add a guard for length and only call playAudio for non-empty strings?

return;
}
setIsLoading(true);
Expand Down